gemini-code-assist[bot] commented on code in PR #38518:
URL: https://github.com/apache/beam/pull/38518#discussion_r3250247689
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -859,13 +859,13 @@ class BeamModulePlugin implements Plugin<Project> {
netty_tcnative_boringssl_static :
"io.netty:netty-tcnative-boringssl-static:2.0.52.Final",
netty_transport :
"io.netty:netty-transport:$netty_version",
netty_transport_native_epoll :
"io.netty:netty-transport-native-epoll:$netty_version",
- opentelemetry_api :
"io.opentelemetry:opentelemetry-api", // google_cloud_platform_libraries_bom
sets version
+ opentelemetry_api :
"io.opentelemetry:opentelemetry-api", // opentelemetry-bom sets version
Review Comment:
The issue #30505 specifically mentions that `opentelemetry-api` and
`opentelemetry-sdk` are missing versions in the generated POMs. While you've
added an explicit version for `opentelemetry_context` at line 864,
`opentelemetry_api` still lacks one. It should likely be updated to include
`$opentelemetry_version` to ensure it is correctly propagated to the archetype
POMs.
```
opentelemetry_api :
"io.opentelemetry:opentelemetry-api:$opentelemetry_version", //
opentelemetry-bom sets version
```
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -859,13 +859,13 @@ class BeamModulePlugin implements Plugin<Project> {
netty_tcnative_boringssl_static :
"io.netty:netty-tcnative-boringssl-static:2.0.52.Final",
netty_transport :
"io.netty:netty-transport:$netty_version",
netty_transport_native_epoll :
"io.netty:netty-transport-native-epoll:$netty_version",
- opentelemetry_api :
"io.opentelemetry:opentelemetry-api", // google_cloud_platform_libraries_bom
sets version
+ opentelemetry_api :
"io.opentelemetry:opentelemetry-api", // opentelemetry-bom sets version
opentelemetry_bom :
"io.opentelemetry:opentelemetry-bom-alpha:$opentelemetry_version-alpha", //
alpha required by extensions
- opentelemetry_context :
"io.opentelemetry:opentelemetry-context", //
google_cloud_platform_libraries_bom sets version
+ opentelemetry_context :
"io.opentelemetry:opentelemetry-context:$opentelemetry_version", // Set version
explicitly as it's standalone runtime dep for Beam modules
opentelemetry_gcp_auth :
"io.opentelemetry.contrib:opentelemetry-gcp-auth-extension:$opentelemetry_contrib_version-alpha",
- opentelemetry_sdk :
"io.opentelemetry:opentelemetry-sdk", // google_cloud_platform_libraries_bom
sets version
- opentelemetry_exporter_otlp :
"io.opentelemetry:opentelemetry-exporter-otlp", //
google_cloud_platform_libraries_bom sets version
- opentelemetry_extension_autoconfigure :
"io.opentelemetry:opentelemetry-sdk-extension-autoconfigure", //
google_cloud_platform_libraries_bom sets version
+ opentelemetry_sdk :
"io.opentelemetry:opentelemetry-sdk", // opentelemetry-bom sets version
+ opentelemetry_exporter_otlp :
"io.opentelemetry:opentelemetry-exporter-otlp", // opentelemetry-bom sets
version
+ opentelemetry_extension_autoconfigure :
"io.opentelemetry:opentelemetry-sdk-extension-autoconfigure", //
opentelemetry-bom sets version
Review Comment:
Similar to `opentelemetry_api`, these artifacts (`sdk`, `exporter-otlp`, and
`autoconfigure`) should also have explicit versions to resolve the issues
reported in #30505 regarding missing versions in published POMs used by
archetypes.
```
opentelemetry_sdk :
"io.opentelemetry:opentelemetry-sdk:$opentelemetry_version", //
opentelemetry-bom sets version
opentelemetry_exporter_otlp :
"io.opentelemetry:opentelemetry-exporter-otlp:$opentelemetry_version", //
opentelemetry-bom sets version
opentelemetry_extension_autoconfigure :
"io.opentelemetry:opentelemetry-sdk-extension-autoconfigure:$opentelemetry_version",
// opentelemetry-bom sets version
```
##########
sdks/java/maven-archetypes/examples/src/main/resources/META-INF/maven/archetype-metadata.xml:
##########
@@ -23,7 +23,7 @@
<requiredProperties>
<requiredProperty key="targetPlatform">
- <defaultValue>1.8</defaultValue>
+ <defaultValue>11</defaultValue>
Review Comment:
Upgrading the default `targetPlatform` from `1.8` to `11` is a breaking
change for users of these archetypes who are still on Java 8. This change
should be explicitly documented in the PR description and `CHANGES.md`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
