Abacn commented on code in PR #38518:
URL: https://github.com/apache/beam/pull/38518#discussion_r3250470837
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -859,13 +859,13 @@ class BeamModulePlugin implements Plugin<Project> {
netty_tcnative_boringssl_static :
"io.netty:netty-tcnative-boringssl-static:2.0.52.Final",
netty_transport :
"io.netty:netty-transport:$netty_version",
netty_transport_native_epoll :
"io.netty:netty-transport-native-epoll:$netty_version",
- opentelemetry_api :
"io.opentelemetry:opentelemetry-api", // google_cloud_platform_libraries_bom
sets version
+ opentelemetry_api :
"io.opentelemetry:opentelemetry-api", // opentelemetry-bom sets version
opentelemetry_bom :
"io.opentelemetry:opentelemetry-bom-alpha:$opentelemetry_version-alpha", //
alpha required by extensions
- opentelemetry_context :
"io.opentelemetry:opentelemetry-context", //
google_cloud_platform_libraries_bom sets version
+ opentelemetry_context :
"io.opentelemetry:opentelemetry-context:$opentelemetry_version", // Set version
explicitly as it's standalone runtime dep for Beam modules
opentelemetry_gcp_auth :
"io.opentelemetry.contrib:opentelemetry-gcp-auth-extension:$opentelemetry_contrib_version-alpha",
- opentelemetry_sdk :
"io.opentelemetry:opentelemetry-sdk", // google_cloud_platform_libraries_bom
sets version
- opentelemetry_exporter_otlp :
"io.opentelemetry:opentelemetry-exporter-otlp", //
google_cloud_platform_libraries_bom sets version
- opentelemetry_extension_autoconfigure :
"io.opentelemetry:opentelemetry-sdk-extension-autoconfigure", //
google_cloud_platform_libraries_bom sets version
+ opentelemetry_sdk :
"io.opentelemetry:opentelemetry-sdk", // opentelemetry-bom sets version
+ opentelemetry_exporter_otlp :
"io.opentelemetry:opentelemetry-exporter-otlp", // opentelemetry-bom sets
version
+ opentelemetry_extension_autoconfigure :
"io.opentelemetry:opentelemetry-sdk-extension-autoconfigure", //
opentelemetry-bom sets version
Review Comment:
These modules are currently only used in java-core, where
enforcePlatform(opentelemetry-bom) is correctly configured. For other places,
only opentelemetry_context is used. Adding a version in beampluginmodule will
force the Beam modules pin on this version.
##########
sdks/java/maven-archetypes/examples/src/main/resources/META-INF/maven/archetype-metadata.xml:
##########
@@ -23,7 +23,7 @@
<requiredProperties>
<requiredProperty key="targetPlatform">
- <defaultValue>1.8</defaultValue>
+ <defaultValue>11</defaultValue>
Review Comment:
WAI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
