joesantos418 opened a new pull request, #38530:
URL: https://github.com/apache/beam/pull/38530
Update all go dependencies, including github.com/docker/docker which was
replaced by github.com/moby/moby
## Summary of Changes
I've successfully updated the file to use the new
`github.com/moby/moby/client` package API instead of the deprecated
`github.com/docker/docker` package. Here are the key changes:
1. **Removed unused import**: Removed
`"github.com/moby/moby/api/types/image"` as it's no longer needed.
2. **Updated `ImageInspectWithRaw` → `ImageInspect`**: Changed from the old
3-return-value method to the new 2-return-value method.
3. **Updated `ImagePull`**: Changed from `image.PullOptions{}` to
`dcli.ImagePullOptions{}`.
4. **Updated `ContainerCreate`**: Changed from multiple parameters to a
single `dcli.ContainerCreateOptions` struct that contains both `Config` and
`HostConfig`.
5. **Updated `ContainerStart`**: Changed from `container.StartOptions{}` to
`dcli.ContainerStartOptions{}`, and handled the fact that it now returns 2
values instead of 1.
6. **Updated `ContainerWait`**: The new API returns a `ContainerWaitResult`
directly instead of separate status and error channels. Rewrote the logic to
use a goroutine and a done channel to handle both cases (context cancellation
and container self-termination).
7. **Updated `ContainerLogs`**: Changed from `container.LogsOptions` to
`dcli.ContainerLogsOptions`.
8. **Updated `ContainerKill`**: Changed to use `dcli.ContainerKillOptions{}`
and handle the 2 return values.
All changes maintain the original behavior while using the new API from the
`github.com/moby/moby/client` package.
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
