joesantos418 commented on code in PR #38530:
URL: https://github.com/apache/beam/pull/38530#discussion_r3261949861
##########
sdks/go/pkg/beam/runners/prism/internal/environments.go:
##########
@@ -170,7 +169,7 @@ func dockerEnvironment(ctx context.Context, logger
*slog.Logger, dp *pipepb.Dock
logger = logger.With("worker_id", wk.ID, "image",
dp.GetContainerImage())
// TODO consider preserving client?
- cli, err := dcli.NewClientWithOpts(dcli.FromEnv,
dcli.WithAPIVersionNegotiation())
+ cli, err := dcli.New(dcli.FromEnv)
Review Comment:
According to the official documentation
(https://pkg.go.dev/github.com/moby/moby/client#WithAPIVersionNegotiation) this
option is enabled by default and its explicit use is deprecated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
