gemini-code-assist[bot] commented on code in PR #38532:
URL: https://github.com/apache/beam/pull/38532#discussion_r3262781641
##########
sdks/go/pkg/beam/runners/dataflow/dataflow.go:
##########
@@ -349,8 +349,9 @@ func getJobOptions(ctx context.Context, streaming bool)
(*dataflowlib.JobOptions
if strings.Contains(e, "use_portable_job_submission") {
portaSubmission = true
}
- if strings.Contains(e, "disable_runner_v2") ||
strings.Contains(e, "disable_runner_v2_until_2023") || strings.Contains(e,
"disable_prime_runner_v2") {
- return nil, errors.New("detected one of the following
experiments: disable_runner_v2 | disable_runner_v2_until_2023 |
disable_prime_runner_v2. Disabling runner v2 is no longer supported as of Beam
version 2.45.0+")
+ // enable_portable_runner is not documented and hence wont be
set by default. This will be fixed in later versions.
+ if strings.Contains(e, "disable_runner_v2") ||
strings.Contains(e, "disable_runner_v2_until_2023") || strings.Contains(e,
"disable_prime_runner_v2") || strings.Contains(e, "disable_portable_runner") ||
strings.Contains(e, "enable_streaming_java_runner") {
+ return nil, errors.New("detected one of the following
experiments: disable_runner_v2 | disable_runner_v2_until_2023 |
disable_prime_runner_v2 | disable_portable_runner |
enable_streaming_java_runner. Disabling runner v2 is no longer supported as of
Beam version 2.45.0+")
Review Comment:
For consistency with the rest of the changes in this PR and the Python SDK
implementation, "runner v2" in the error message should be updated to "Portable
Runner".
```suggestion
return nil, errors.New("detected one of the following
experiments: disable_runner_v2 | disable_runner_v2_until_2023 |
disable_prime_runner_v2 | disable_portable_runner |
enable_streaming_java_runner. Disabling Portable Runner is no longer supported
as of Beam version 2.45.0+")
```
##########
runners/google-cloud-dataflow-java/build.gradle:
##########
@@ -471,7 +471,7 @@ def validatesRunnerStreamingConfig = [
excludedTests: [
// TODO(https://github.com/apache/beam/issues/21472)
'org.apache.beam.sdk.transforms.GroupByKeyTest$BasicTests.testAfterProcessingTimeContinuationTriggerUsingState',
- // GroupIntoBatches.withShardedKey not supported on streaming runner v1
+ // GroupIntoBatches.withShardedKey not supported on streaming Streaming
Java Runner
Review Comment:
The word "streaming" is redundant here as "Streaming Java Runner" already
includes it.
```
// GroupIntoBatches.withShardedKey not supported on Streaming Java Runner
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
