scwhittle commented on code in PR #38532: URL: https://github.com/apache/beam/pull/38532#discussion_r3274072001
########## sdks/python/apache_beam/examples/kafkataxi/README.md: ########## @@ -67,7 +67,7 @@ Perform Beam runner specific setup. ℹ️ Note that cross-language transforms require portable implementations of Spark/Flink/Direct runners. Dataflow requires -[runner V2](https://cloud.google.com/dataflow/docs/guides/deploying-a-pipeline#dataflow-runner-v2). +[Portable Runner](https://cloud.google.com/dataflow/docs/guides/deploying-a-pipeline#dataflow-runner-v2). Review Comment: how about Dataflow requires using the [Dataflow Portable Runner] ########## sdks/go/pkg/beam/runners/dataflow/dataflow_test.go: ########## @@ -244,6 +244,40 @@ func TestGetJobOptions_DisableRunnerV2ExperimentsSet(t *testing.T) { } } +func TestGetJobOptions_DisablePortableRunnerExperimentsSet(t *testing.T) { + resetGlobals() + *stagingLocation = "gs://testStagingLocation" + *gcpopts.Project = "testProject" + *gcpopts.Region = "testRegion" + *jobopts.Experiments = "disable_portable_runner" + + opts, err := getJobOptions(context.Background(), false) + + if err == nil { Review Comment: what are these testing? It seems it is verifying errors, but the test name doesn't indicate we expect a failure. If we do it woudl be better to verify the error more specifically too ditto for the other test ########## sdks/python/apache_beam/runners/dataflow/internal/clients/dataflow/dataflow_v1b3_messages.py: ########## @@ -6764,9 +6764,9 @@ class StreamingConfigTask(_messages.Message): format version for streaming engine jobs. userStepToStateFamilyNameMap: Map from user step names to state families. userWorkerRunnerV1Settings: Binary encoded proto to control runtime - behavior of the java runner v1 user worker. + behavior of the Streaming Java Runner user worker. Review Comment: think this file is generated https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/dataflow/internal/clients/README.txt -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
