lostluck commented on code in PR #38523:
URL: https://github.com/apache/beam/pull/38523#discussion_r3277558302
##########
sdks/go/pkg/beam/runners/prism/internal/stage.go:
##########
@@ -240,7 +240,7 @@ progress:
sr, err := b.Split(ctx, wk, 0.5 /* fraction of
remainder */, nil /* allowed splits */)
if err != nil {
slog.Warn("SDK Error from split,
aborting splits and failing bundle", "bundle", rb, "error", err.Error())
- if b.BundleErr != nil {
+ if b.BundleErr == nil {
b.BundleErr = err
}
Review Comment:
This is true. If the bundle split error happens at the same time as the
bundle finishing (and providing the bundle response), there will be a data race
on the interface pointer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
