lostluck commented on code in PR #38523:
URL: https://github.com/apache/beam/pull/38523#discussion_r3277561954
##########
sdks/go/pkg/beam/runners/prism/internal/worker/bundle.go:
##########
@@ -102,7 +104,11 @@ func (b *B) Respond(resp *fnpb.InstructionResponse) {
return
}
b.responded = true
+ if b.Done != nil {
+ close(b.Done)
+ }
if resp.GetError() != "" {
+ slog.Error("DEBUG: Prism received bundle error from worker
response", "bundle", resp.GetInstructionId())
b.BundleErr = fmt.Errorf("bundle %v %v failed:%v",
resp.GetInstructionId(), b.PBDID, resp.GetError())
Review Comment:
Also a real error. Don't trigger something that might cause a read before
the write it's expected to read. Violates the "happens before" type
relationship.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
