junaiddshaukat commented on PR #38534: URL: https://github.com/apache/beam/pull/38534#issuecomment-4509831715
@je-ik I have pushed a follow-up commit addressing your three concerns : (a) dropped all file-level nullness suppressions; made the classes checker-compliant. One narrow one-line suppression remains on a private helper wrapping setRunner(null) — that's the same Beam idiom Flink/Spark use, happy to refactor if you'd rather avoid it. Also removed the processingGuarantee option per your inline note. (b) added three test classes including one that asserts the translator throws UnsupportedOperationException with "No translator registered for URN ..." on a one-transform Impulse pipeline. These get replaced incrementally as real translators land. (c) added a PreCommit workflow that runs :runners:kafka-streams:build on changes under runners/kafka-streams/**, plus the matching trigger file and registry row. `./gradlew :runners:kafka-streams:check` is green locally. Ready for re-review whenever you have time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
