junaiddshaukat commented on PR #38534: URL: https://github.com/apache/beam/pull/38534#issuecomment-4519464183
@je-ik Pushed a follow-up addressing both threads. dropped the applicationId default and added @Validation.Required, so the validator now fails fast if it's not set instead of letting jobs share a consumer group. For the setRunner(null) bit: just removed the call (and the small suppression with it). The skeleton translator throws on every URN before anything reaches a harness, so clearing the runner isn't really doing anything yet. I'll bring it back in a non-suppressing way when the first real translator lands and the proto actually goes somewhere. No @SuppressWarnings left in the new code. ./gradlew :runners:kafka-streams:check is green locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
