tvalentyn commented on code in PR #37345:
URL: https://github.com/apache/beam/pull/37345#discussion_r3326594886
##########
sdks/python/apache_beam/io/gcp/pubsub_integration_test.py:
##########
@@ -305,6 +305,51 @@ def test_batch_write_with_attributes(self):
"""Test WriteToPubSub in batch mode with attributes."""
self._test_batch_write(with_attributes=True)
+ @pytest.mark.it_postcommit
+ def test_batch_write_with_ordering_key(self):
+ """Test WriteToPubSub in batch mode with ordering keys."""
+ from apache_beam.options.pipeline_options import PipelineOptions
+ from apache_beam.options.pipeline_options import StandardOptions
+ from apache_beam.transforms import Create
+
+ # Create test messages with ordering keys
+ test_messages = [
+ PubsubMessage(
+ b'order_data001', {'attr': 'value1'}, ordering_key='key1'),
+ PubsubMessage(
+ b'order_data002', {'attr': 'value2'}, ordering_key='key1'),
+ PubsubMessage(
+ b'order_data003', {'attr': 'value3'}, ordering_key='key2')
+ ]
+
+ pipeline_options = PipelineOptions()
+ pipeline_options.view_as(StandardOptions).streaming = False
+
+ with TestPipeline(options=pipeline_options) as p:
+ messages = p | 'CreateMessages' >> Create(test_messages)
+ _ = messages | 'WriteToPubSub' >> WriteToPubSub(
+ self.output_topic.name, with_attributes=True)
+
+ # Verify messages were published
+ time.sleep(10)
+
+ response = self.sub_client.pull(
+ request={
+ "subscription": self.output_sub.name,
+ "max_messages": 10,
+ })
+
+ self.assertEqual(len(response.received_messages), len(test_messages))
Review Comment:
if not enough messages were received, could we try to wait and pull again
(with some guardrails to eventually stop) , in case waiting 10 seconds was not
sufficient ? This could help prevent test flakiness.
##########
sdks/python/apache_beam/io/gcp/pubsub.py:
##########
@@ -628,7 +638,10 @@ def __init__(self, transform):
def setup(self):
from google.cloud import pubsub
- self._pub_client = pubsub.PublisherClient()
+ self._pub_client = pubsub.PublisherClient(
+ publisher_options=pubsub.types.PublisherOptions(
+ enable_message_ordering=True,
Review Comment:
should enable_message_ordering be conditionally-enabled here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
