tvalentyn commented on code in PR #37345:
URL: https://github.com/apache/beam/pull/37345#discussion_r3343661859
##########
sdks/python/apache_beam/io/gcp/pubsub.py:
##########
@@ -638,10 +639,13 @@ def __init__(self, transform):
def setup(self):
from google.cloud import pubsub
- self._pub_client = pubsub.PublisherClient(
- publisher_options=pubsub.types.PublisherOptions(
- enable_message_ordering=True,
- ))
+ if self.with_attributes:
Review Comment:
> Also changed the initialization of with_ordering in __init__ to derive
from transform.with_attributes, so ordering is enabled only when the feature is
actually requested rather than being hardcoded to True.
Is it feasible to derive based on whether ordering was requested?
with_attributes seems more general.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
