Eliaaazzz commented on PR #38724: URL: https://github.com/apache/beam/pull/38724#issuecomment-4602387242
@Abacn I pushed an update addressing your latest review feedback. Summary: - cleaned user-facing pydoc and private comments - kept `ReadFromUnboundedSource` docs focused on `beam.io.Read` - added warning coverage for close errors while preserving processing failures - updated `UnboundedCountingSource` tests with realistic timestamps, `@override` usage, and optional even/odd splitting - kept `CHANGES.md` unchanged Verified: `python -m pytest -q sdks/python/apache_beam/io/unbounded_source_test.py sdks/python/apache_beam/io/iobase_test.py -q` Could you please take another look when you have time? Would you prefer the PR branch squashed further before the next review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
