Eliaaazzz commented on PR #38724: URL: https://github.com/apache/beam/pull/38724#issuecomment-4622288851
Hi @Abacn, thanks for the continued review. I pushed one squashed follow-up commit after the reviewed commit for incremental review. Changes: - made the unbounded `Read` boundedness test graph-only - moved portability imports to module scope - removed new-file pytype skips - clarified checkpoint finalization as best-effort at-most-once and aligned the tests - removed the generic pickle/subprocess/syntax tests - kept `UnboundedSource` `Read` on the expanded composite runner API path, with a regression test for avoiding deprecated `READ` serialization Verified locally: - `python -m pytest -q sdks/python/apache_beam/io/unbounded_source_test.py sdks/python/apache_beam/io/iobase_test.py -q` - `./gradlew :pythonFormatterPreCommit --console=plain` - `./gradlew :pythonLintPreCommit --console=plain` - `./gradlew :sdks:python:test-suites:tox:py310:testPython310 --console=plain` I would appreciate another look when you have time. Thanks again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
