kennknowles commented on code in PR #38454:
URL: https://github.com/apache/beam/pull/38454#discussion_r3396922745
##########
runners/core-java/src/main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java:
##########
@@ -231,7 +231,7 @@ public void finishBundle() {
}
@Override
- public void finishKey() {}
+ public <KeyT extends @Nullable Object> void finishKey(KeyT key) {}
Review Comment:
Hmm I see. You should have pushed back :-)
Now that I look at the surrounding code I see you are just being consistent
with it all. I think all the code is a bit off but you should just be
consistent for now.
Sorry!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
