arunpandianp commented on code in PR #38454:
URL: https://github.com/apache/beam/pull/38454#discussion_r3397217659
##########
runners/core-java/src/main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java:
##########
@@ -231,7 +231,7 @@ public void finishBundle() {
}
@Override
- public void finishKey() {}
+ public <KeyT extends @Nullable Object> void finishKey(KeyT key) {}
Review Comment:
No problem. Thanks for checking. I reverted the change to Object. Also, to
keep this change simple, removed the sideinput related change i had in the
SideInputDoFnRunners. Now the change is a no op, just adding the finishKey
hooks. Will fill in logic in later PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
