arunpandianp commented on code in PR #38991:
URL: https://github.com/apache/beam/pull/38991#discussion_r3424562804
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/WindmillTimerInternals.java:
##########
@@ -64,6 +64,19 @@ class WindmillTimerInternals implements TimerInternals {
private final Consumer<TimerData> onTimerModified;
private final WindmillTagEncoding windmillTagEncoding;
+ private boolean poisoned = false;
Review Comment:
The class is expected to be used by a single thread and no synchronization
is needed.
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/state/WindmillStateInternals.java:
##########
@@ -55,6 +55,19 @@ public class WindmillStateInternals<K> implements
StateInternals {
private final CachingStateTable workItemDerivedState;
private final Supplier<Closeable> scopedReadStateSupplier;
+ private boolean poisoned = false;
Review Comment:
The class is expected to be used by a single thread and no synchronization
is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
