arunpandianp commented on code in PR #38991:
URL: https://github.com/apache/beam/pull/38991#discussion_r3424564389
##########
runners/core-java/src/main/java/org/apache/beam/runners/core/LateDataDroppingDoFnRunner.java:
##########
@@ -116,13 +116,12 @@ public <KeyT> void onWindowExpiration(BoundedWindow
window, Instant timestamp, K
@VisibleForTesting
static class LateDataFilter {
private final WindowingStrategy<?, ?> windowingStrategy;
- private final TimerInternals timerInternals;
+ private final StepContext stepContext;
private final Counter droppedDueToLateness;
- public LateDataFilter(
- WindowingStrategy<?, ?> windowingStrategy, TimerInternals
timerInternals) {
+ public LateDataFilter(WindowingStrategy<?, ?> windowingStrategy,
StepContext stepContext) {
this.windowingStrategy = windowingStrategy;
- this.timerInternals = timerInternals;
+ this.stepContext = stepContext;
Review Comment:
Keeping it consistent with other fields around the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
