gemini-code-assist[bot] commented on code in PR #39112:
URL: https://github.com/apache/beam/pull/39112#discussion_r3476436965
##########
sdks/python/apache_beam/io/requestresponse.py:
##########
@@ -375,7 +375,8 @@ def process(self, request: RequestT, *args, **kwargs):
response = self._repeater.repeat(
self._caller, request, self._timeout, self._metrics_collector)
self._metrics_collector.responses.inc(1)
- self._throttler.throttler.successful_request(req_time * MSEC_TO_SEC)
+ if self._throttler:
Review Comment:
According to PEP 8, comparisons to singletons like `None` should always be
done with `is` or `is not`, never the equality operators or implicit boolean
evaluation when checking if an optional argument/attribute is set. Using `is
not None` is safer and more explicit.
```suggestion
if self._throttler is not None:
```
<details>
<summary>References</summary>
1. PEP 8: Use 'is not None' when testing whether a variable or argument that
defaults to None was set to some other value.
<sup>([link](http://console.cloud.google.com/gemini-code-assist/agents-tools))</sup>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
