damccorm commented on code in PR #39112:
URL: https://github.com/apache/beam/pull/39112#discussion_r3481885033
##########
sdks/python/apache_beam/ml/inference/pytorch_inference_test.py:
##########
@@ -619,9 +619,10 @@ def batch_validator_keyed_tensor_inference_fn(
inference_args,
model_id,
):
- if len(batch) != 2:
+ if len(batch) > 2:
raise Exception(
- f'Expected batch of size 2, received batch of size {len(batch)}')
+ 'Expected batch size 1 or 2, received batch of size '
+ f'{len(batch)}')
Review Comment:
Why are we including this change? It seems like this changes the meaning of
the test (incorrectly)
In general, it is better to keep PRs focused on a single task
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
