Eliaaazzz opened a new pull request, #39191:
URL: https://github.com/apache/beam/pull/39191
Splittable DoFns that self-checkpoint on the portable Flink runner leaked
keyed state without bound. `StateAndTimerBundleCheckpointHandler.onCheckpoint`
wrote each residual under a fresh, unique `ValueState` tag
(`sdf_checkpoint:<id>:<index>`), so a polling SDF (for example one using
`tracker.defer_remainder()`) registered a new Flink keyed-state descriptor in
`registeredKVStates` on every self-checkpoint, and the job's heap grew until it
OOMed.
This stores all residuals for a key and window under a single stable
`MapState` (`sdf_checkpoint_residuals`) keyed by the per-residual checkpoint
id, and removes each entry once its timer fires and the residual is
re-processed. Both read paths, streaming `ExecutableStageDoFnOperator.onTimer`
and batch `FlinkExecutableStageFunction`, look the residual up by timer id.
Timer ids stay dynamic; Flink already keeps them in a stable pending-timers map
that is cleared on fire.
Residuals persisted by the previous code under per-residual `ValueState`
tags are not migrated, so an in-flight residual from an older savepoint is
dropped on this experimental portability path.
`BundleCheckpointHandlersTest` drives repeated self-checkpoints through the
handler and asserts a single keyed-state descriptor is used regardless of the
number of self-checkpoints; it fails on the previous per-residual behavior.
Fixes #27648
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [x] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [x] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
