Eliaaazzz commented on PR #39191: URL: https://github.com/apache/beam/pull/39191#issuecomment-4862260454
Thanks for the review! On the TODO at L735, I removed `// TODO: Fail on splittable DoFns.` since SDFs now work as expected. The adjacent `// TODO: Special-case single outputs to avoid multiplexing PCollections.` is about output multiplexing rather than SDF support and is still not implemented, so I left it in. Happy to remove that one too if you meant both. I also applied the same fix to the branched `runners/flink/2.0` copy of `FlinkExecutableStageFunction`, and added the null checks Gemini flagged for the old-savepoint read path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
