damccorm commented on PR #37186: URL: https://github.com/apache/beam/pull/37186#issuecomment-4993305855
This mostly LGTM, my only lingering concerns are around the batching > I will resolve the conflicts later to avoid breaking the reviewed code Thanks! I will note that you can do this without rebasing if you create a merge commit instead: ``` git fetch origin git merge origin/master ``` That will allow you to resolve the conflicts without breaking the review feature -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
