kennknowles commented on a change in pull request #12981:
URL: https://github.com/apache/beam/pull/12981#discussion_r497856286



##########
File path: runners/portability/java/build.gradle
##########
@@ -82,8 +87,15 @@ void execBackgroundInVirtualenv(String... args) {
   proc.waitFor();
 }
 
-task startLocalJobService {
+task installBeamPythonInVirtualenv {
   dependsOn setupVirtualenv
+  doLast {
+    execInVirtualenv "pip", "install", "-e", "."

Review comment:
       So you mean more of an approach like this?
   
   ```
          dependsOn ':sdks:python:sdist'
           doLast {
             def distTarBall = "${pythonRootDir}/build/apache-beam.tar.gz"
             project.exec {
               executable 'sh'
               args '-c', ". ${project.ext.envdir}/bin/activate && pip install 
--retries 10 ${distTarBall}"
             }
           }
         }
   ```
   
   I am not familiar with the install variants. For ValidatesRunner we should 
not need any cloud-specific things. I do not know what `test` changes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to