tvalentyn commented on a change in pull request #12981:
URL: https://github.com/apache/beam/pull/12981#discussion_r497864103
##########
File path: runners/portability/java/build.gradle
##########
@@ -82,8 +87,15 @@ void execBackgroundInVirtualenv(String... args) {
proc.waitFor();
}
-task startLocalJobService {
+task installBeamPythonInVirtualenv {
dependsOn setupVirtualenv
+ doLast {
+ execInVirtualenv "pip", "install", "-e", "."
Review comment:
Race condition between comment updates, did not see your prior comments.
[test] installs additional dependencies mentioned in
https://github.com/apache/beam/blob/e6b3cf1da5f17a3a15f2a48986a1b84266f3a64c/sdks/python/setup.py#L176
Same applies for other 'extra' dependencies.
Your proposal sounds good to me. I would move :
installBeamPythonInVirtualenv into BeamModulePlugin.groovy ->
installBeamPython, but feel free to keep here if you feel strongly about it.
In a future change we can rename installGcpTest to
installBeamPythonWithAllExtraDeps
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
