tvalentyn commented on code in PR #39484:
URL: https://github.com/apache/beam/pull/39484#discussion_r3683188285
##########
sdks/python/container/profiler.go:
##########
@@ -334,3 +354,185 @@ func needsProcessing(binInfo os.FileInfo, path string)
bool {
// Don't regenerate when there were no updates to the profile.
return binInfo.ModTime().After(info.ModTime())
}
+
+func monitorCoredumpsLoop(ctx context.Context, logger *tools.Logger, pcfg
*ProfilerConfig) {
+ // We require the core file pattern to be configured as
"/tmp/core.%e.%p" via pipeline
+ // options experiments (which is automatically set by the Python SDK).
This ensures
+ // that core dumps are written in /tmp/ with a prefix matching "core.".
+ coreDir := "/tmp"
+ interval := 5 * time.Second
Review Comment:
yeah, this 5 second constant is useless, let's remove this altogether.
Re 600... not sure; probably won't eat a ton of CPU to do it more
frequently, we can lower to 60sec. the ticker should not run concurrently,
perhaps the issue might happen if the core cannot be processed or deleted, and
keeps getting reprocessed again and again... hopefully that's not common
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
