tvalentyn commented on code in PR #39484:
URL: https://github.com/apache/beam/pull/39484#discussion_r3685208132
##########
sdks/python/container/profiler.go:
##########
@@ -334,3 +354,185 @@ func needsProcessing(binInfo os.FileInfo, path string)
bool {
// Don't regenerate when there were no updates to the profile.
return binInfo.ModTime().After(info.ModTime())
}
+
+func monitorCoredumpsLoop(ctx context.Context, logger *tools.Logger, pcfg
*ProfilerConfig) {
+ // We require the core file pattern to be configured as
"/tmp/core.%e.%p" via pipeline
+ // options experiments (which is automatically set by the Python SDK).
This ensures
+ // that core dumps are written in /tmp/ with a prefix matching "core.".
+ coreDir := "/tmp"
+ interval := 5 * time.Second
Review Comment:
actually i'll keep it 600 sec since the same param is used by other
profilers, which might be resource-intensive. Users can set the lower value
manually but I suspect this will be good enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
