junaiddshaukat commented on code in PR #39546:
URL: https://github.com/apache/beam/pull/39546#discussion_r3689345387
##########
runners/kafka-streams/src/main/java/org/apache/beam/runners/kafka/streams/translation/FlattenProcessor.java:
##########
@@ -99,8 +99,7 @@ public void process(Record<byte[], KStreamsPayload<?>>
record) {
Instant advanced = watermarkAggregator.advance();
if (advanced.isAfter(lastForwardedWatermark)) {
lastForwardedWatermark = advanced;
- // Stamped with this Flatten's own transform id; Flatten is a single
instance for now, so the
- // report is for its only partition (0 of 1).
+ // Stamped as the only source a consumer will see; a shuffle downstream
restamps.
Review Comment:
Good point, that reads wrong. Switched to "label"/"relabel" throughout, the
shuffle relabels the report with the reporting instance's identity, which is
what it actually does and doesn't collide with timestamps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
