junaiddshaukat commented on code in PR #39546:
URL: https://github.com/apache/beam/pull/39546#discussion_r3689365178
##########
runners/kafka-streams/src/main/java/org/apache/beam/runners/kafka/streams/KafkaStreamsPipelineOptions.java:
##########
@@ -55,6 +55,21 @@ public interface KafkaStreamsPipelineOptions extends
PortablePipelineOptions {
void setMaxBundleTimeMs(int maxBundleTimeMs);
+ @Description(
+ "Number of partitions for the topics the runner creates for a pipeline
(the bootstrap topic"
+ + " of each Impulse and Read, and the repartition topic of each
GroupByKey). This is the"
+ + " parallelism the shuffled parts of the pipeline can reach.")
+ @Default.Integer(1)
+ int getTopicPartitions();
+
+ void setTopicPartitions(int topicPartitions);
+
+ @Description("Replication factor for the topics the runner creates for a
pipeline.")
+ @Default.Short(1)
+ short getTopicReplicationFactor();
Review Comment:
Agreed, filed: https://github.com/apache/beam/issues/39565. Noted both ideas
there — a JSON-serialized dictionary and/or the most common ones as separate
options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
