ahmedabu98 commented on code in PR #39600:
URL: https://github.com/apache/beam/pull/39600#discussion_r3721346958
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/IcebergIO.java:
##########
@@ -693,6 +712,35 @@ public ReadRows withFilter(@Nullable String filter) {
return toBuilder().setFilter(filter).build();
}
+ public ReadRows withWatermarkColumn(@Nullable String watermarkColumn) {
+ return toBuilder().setWatermarkColumn(watermarkColumn).build();
+ }
+
+ public ReadRows withWatermarkColumnTimeUnit(@Nullable String timeUnit) {
+ return toBuilder().setWatermarkColumnTimeUnit(timeUnit).build();
+ }
+
+ public ReadRows withMaxSnapshotDiscoveryDelay(@Nullable Duration delay) {
+ return toBuilder().setMaxSnapshotDiscoveryDelay(delay).build();
+ }
+
+ /**
+ * Appends top-level metadata columns to CDC output rows.
+ *
+ * <p>Supported values are {@code _change_type}, {@code
_commit_snapshot_id}, {@code
+ * _commit_snapshot_sequence_number}, {@code _row_id}, and {@code
+ * _last_updated_sequence_number}. The row metadata columns are read from
Iceberg data files and
+ * require a row-lineage table. The changelog metadata columns come from
the emitted change kind
+ * and snapshot context and are appended when final Beam rows are emitted.
+ *
+ * <p>This option is only valid {@link #withCdc()}.
Review Comment:
It does in `IcebergScanConfig#validate`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
