ahmedabu98 commented on code in PR #39600:
URL: https://github.com/apache/beam/pull/39600#discussion_r3723567201
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/IcebergCdcReadSchemaTransformProvider.java:
##########
@@ -211,12 +207,6 @@ static Builder builder() {
+ "MILLISECONDS, SECONDS, MINUTES, HOURS, DAYS. Defaults to
MICROSECONDS.")
abstract @Nullable String getWatermarkColumnTimeUnit();
- @SchemaFieldDescription(
- "Maximum expected snapshot discovery delay in seconds. While idle, the
source may advance "
Review Comment:
Yeah we no longer need it after the fix mentioned in
https://github.com/apache/beam/pull/39600#discussion_r3722389897
Only had it to allow customers to control what we would consider "late". but
now even if the catalog is slow/down, we wouldn't consider the missed snapshots
as late. We just weave them in and attach current watermark as timestamp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
