bvolpato commented on code in PR #39658:
URL: https://github.com/apache/beam/pull/39658#discussion_r3733064321
##########
release/src/main/groovy/TestScripts.groovy:
##########
@@ -187,6 +224,26 @@ class TestScripts {
return output_text
}
+ // Run a single command asynchronously in the background
+ private Process _executeBackground(String cmd) {
+ def shell = "sh -c cmd".split(' ')
+ shell[2] = cmd
+ def pb = new ProcessBuilder(shell)
+ pb.directory(var.curDir)
+ pb.redirectErrorStream(true)
+ def proc = pb.start()
Review Comment:
Could we retain and check background process exit status here?
`_executeBackground` only drains stdout, and `stopProcess` removes an
already-exited process without inspecting its result. DirectRunner keeps
`leaderboard_DirectRunner_*` tables, so failed Injector or LeaderBoard commands
can match stale rows and report `[SUCCESS]`. Reproduced with both background
Maven commands exiting 42 while script exited 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
