Abacn commented on code in PR #39658:
URL: https://github.com/apache/beam/pull/39658#discussion_r3738782651
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -2643,7 +2643,7 @@ class BeamModulePlugin implements Plugin<Project> {
JavaExamplesArchetypeValidationConfiguration config = it as
JavaExamplesArchetypeValidationConfiguration
def taskName = "run${config.type}Java${config.runner}"
- def releaseVersion = project.findProperty('ver') ?: project.version
+ def releaseVersion = (project.findProperty('ver') &&
project.findProperty('ver') != '2.XX.0') ? project.findProperty('ver') :
project.version
Review Comment:
nit: Logically not recommending changing the common BeamModulePlugin.groovy
to accommodate a specific workflow, beam_PostRelease_NightlySnapshot.yml.
Instead, we can change the workflow like
```
-Pver='${{ (github.event.inputs.RELEASE == "2.xx.0" || '') ||
github.event.inputs.RELEASE }}'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
