bvolpato commented on PR #39619: URL: https://github.com/apache/beam/pull/39619#issuecomment-5223608533
Thanks! I will look a bit deeper and implement some benchmarks with large schemas/nested fields, it makes sense! Will keep this as draft for now. But yes, the advantage ends up being a much faster creation (for every schema), and way less bookkeeping of the generated classes, as JVM retains class metadata for everything instantiated. At the steady state, after it's classloaded and JIT has ran, it shouldn't make much difference. (Also I think it simplifies the code considerably, which might be a win by itself.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
