PDGGK commented on PR #39712: URL: https://github.com/apache/beam/pull/39712#issuecomment-5248554533
Flagging a collision I should have caught before opening this: **#39711 by @waterWang covers the same three sites and was opened first.** Timestamps, so nobody has to reconstruct them: | | | |---|---| | issue #39710 filed | 02:12:36Z | | **#39711 opened** | **02:20:11Z** | | this PR opened | 02:30:57Z | I checked for existing PRs on `HBaseIO` before filing the issue, but not again in the eighteen minutes between the issue and this PR — that was my mistake, and #39711 landed inside exactly that window. The two fixes are equivalent in approach: run every teardown step, keep the first failure, attach the rest as suppressed. The difference is that this one also adds `HBaseIOCloseTest` (5 cases, including one asserting `HBaseSharedConnection`'s real reference count returns to zero) and verifies each teardown individually — reverting one at a time fails exactly and only its own test. I have no interest in a race here. If a committer prefers #39711, say so and I'll close this immediately; I've offered the tests over there so they can be folded in either way. Happy to go whichever direction gets the fix in with coverage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
