arunpandianp commented on code in PR #39473: URL: https://github.com/apache/beam/pull/39473#discussion_r3787715125
########## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingModeExecutionContext.java: ########## Review Comment: It is a good idea to stop merging when we hit a limit including state updates. We can accumulate the individual commit size from flushStateInternal and compare that against a threshold. Will send a separate change for that. We flush key state per key and truncation is only based on individual key commit size, so I'm not sure if counting the state updates will reduce truncations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
