arunpandianp commented on code in PR #39473:
URL: https://github.com/apache/beam/pull/39473#discussion_r3809192513
##########
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorkerTest.java:
##########
@@ -4884,6 +4890,395 @@ public void
testSkipInputElementsWithDecodingExceptions() throws Exception {
"12345",
commit.getOutputMessages(0).getBundles(0).getMessages(0).getData().toStringUtf8());
}
+ @Test
+ public void testMultiKeyCommit_batchCommitSizeExceededUnBatchSucceeds()
throws Exception {
+ if (!streamingEngine) {
+ return;
+ }
+ KvCoder<String, String> kvCoder = KvCoder.of(StringUtf8Coder.of(),
StringUtf8Coder.of());
+
+ List<ParallelInstruction> instructions =
+ Arrays.asList(
+ makeSourceInstruction(kvCoder),
+ makeDoFnInstruction(new FixedSizeCommitFn(500), 0, kvCoder),
Review Comment:
done. Updated tests to use a DoFn writing to state instead of using
productions. Added a todo to add tests using productions. Need to send a
WindmillSink change to flush productions in finishKey.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
