Eliaaazzz opened a new pull request, #39823:
URL: https://github.com/apache/beam/pull/39823
`GlobalWatermarkHolder.advance()` rebuilt the global watermark map from only
the sources that had a queued update for the completed batch and overwrote the
stored map with the result. A source that reported no progress in that batch
lost its last known watermark, and since
`SparkTimerInternals.forStreamFromSources` skips ids that are missing from the
map, the input watermark of every consuming stage jumped ahead of the idle
source, firing timers early and dropping its later elements as late.
`computeNewWatermarks` now starts from the stored map and merges the
per-source updates over it, so an idle source keeps its last watermark until it
reports again. A source whose high watermark reached the end of time is done
and holds nothing back, so it is not retained past the batch that completed it;
without this, its finite synchronized processing time and low watermark would
constrain consumers forever. Retained sources can disagree on the synchronized
processing time, so `SparkTimerInternals` takes the slowest one instead of
asserting equality. The stored map is also read once per `advance()` instead of
once per updated source.
Two `CreateStream` test scripts (`testFlattenedWithWatermarkHold`,
`shouldTriggerProcessingTimeTimerWithSparseKey`) now advance their watermarks
to infinity like the other scripts. Their scripts previously stopped at a
finite watermark and the tests only terminated because the dropped source no
longer held the global watermark back; with retention that stalled watermark
would legitimately hold it back until the test timeout.
`testWatermarkRetainedForSourceWithoutUpdate` fails on master with source 2
absent from the map after the second `advance()`; `testCompletedSourceAgesOut`
pins the report-then-age-out behavior.
Fixes #39822.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [x] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [x] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
