damccorm commented on code in PR #39823:
URL: https://github.com/apache/beam/pull/39823#discussion_r3980776565
##########
runners/spark/src/main/java/org/apache/beam/runners/spark/util/GlobalWatermarkHolder.java:
##########
@@ -240,7 +252,7 @@ private static Map<Integer, SparkWatermarks>
computeNewWatermarks(BlockManager b
new SparkWatermarks(nextLowWatermark, nextHighWatermark,
nextSynchronizedProcessingTime));
}
- return newValues;
+ return hasUpdates ? newValues : new HashMap<>();
Review Comment:
How is this used/why do we only return if there are updates? Does it
actually save us anything?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
