Eliaaazzz commented on code in PR #39746:
URL: https://github.com/apache/beam/pull/39746#discussion_r3819852849
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Watch.java:
##########
@@ -899,13 +941,26 @@ public ProcessContinuation process(
return stop();
}
+ PollingGrowthState<TerminationStateT> pollingRestriction =
+ (PollingGrowthState<TerminationStateT>) currentRestriction;
+
+ Duration allowedLateness = spec.getTimestampCursorAllowedLateness();
Review Comment:
Done, commit f2f1173.
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Watch.java:
##########
@@ -1305,7 +1490,9 @@ public GrowthState decode(InputStream is) throws
IOException {
case NON_POLLING_GROWTH_STATE:
return decodeNonPollingGrowthState(is);
case POLLING_GROWTH_STATE:
- return decodePollingGrowthState(is);
+ return decodePollingGrowthState(is, false);
Review Comment:
Added a test pinning the encoded forms byte for byte. I generated the
expected bytes by running the same two states through the coder built from
master before this branch, and this branch produces identical bytes, so the
literals in the test are the pre-cursor encoding. Commit f2f1173.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
