Eliaaazzz commented on PR #39746: URL: https://github.com/apache/beam/pull/39746#issuecomment-5353364200
Checked, and it applied here the same way: an empty round with no explicit watermark left the watermark where it was. With the cursor this is now fixable inside Watch itself. computeNeverSeenBeforeResults drops everything below the retention floor, so no later round can emit below it, and an empty round now advances the watermark to the floor. Without the cursor there is no such bound, so the hash path keeps the conservative behavior and the poll fn stays responsible for the watermark, which MatchPollFn already does with withWatermark(now). Commit f2f1173, with a test that has the watermark stuck at the minimum without the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
