Eliaaazzz commented on PR #39572: URL: https://github.com/apache/beam/pull/39572#issuecomment-5365952037
> > Looked into the run. Attempt 1 failed on ActiveMQJmsIOTest.test_xlang_jms_write_read_queue with 0 != 100 and the rerun of the same commit passed. That suite runs the Python DirectRunner with a Java expansion service, so prism is not on the execution path. The same workflow failed twice on master in its last twenty runs without this change, both in the same file with the same 0 != 100 shape, IbmMqJmsIOTest.test_xlang_jms_write_read_queue_client_ack on Aug 16 and Aug 17. So I read it as pre existing flakiness in the new JMS suite rather than something this change introduced. Happy to file a flaky test issue for it. > > (Sorry for replying to wrong thread previously) > > These tests do use prism runner: > > https://github.com/apache/beam/blob/93f3e051c3ef47238711eb4f313d7e01477c42c3/sdks/python/test-suites/direct/common.gradle#L454 > > My comment was about this does fix the flakiness seen in the JmsIO test to some extent. Since this PR closes #39446, can we apply [f274b1b](https://github.com/apache/beam/commit/f274b1b35a14123afb17547cae9e2e5683864ab2) here (remove 5s delay) and trigger PostCommit Python Xlang Messaging Direct? Thanks! Thanks for the good call. I have done that! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
