damccorm commented on code in PR #39834:
URL: https://github.com/apache/beam/pull/39834#discussion_r3829555366
##########
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcReadSchemaTransformProvider.java:
##########
@@ -363,6 +368,11 @@ public abstract static class
JdbcReadSchemaTransformConfiguration implements Ser
@Nullable
public abstract String getReadQuery();
+ @SchemaFieldDescription(
+ "Secret Manager to use for fetching secret values. For example,
GoogleCloudSecretManager.")
Review Comment:
I think we need a few things to improve the docs here:
1) An example of the full secret manager string and how it is used (this
would go in password, not here I guess).
2) A set of allowed secret managers for the default expansion service.
It might make sense to abstract this out to a small doc since it will
probably show up in several places.
##########
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcReadSchemaTransformProvider.java:
##########
@@ -363,6 +368,11 @@ public abstract static class
JdbcReadSchemaTransformConfiguration implements Ser
@Nullable
public abstract String getReadQuery();
+ @SchemaFieldDescription(
+ "Secret Manager to use for fetching secret values. For example,
GoogleCloudSecretManager.")
Review Comment:
Generally, the same feedback applies to the yaml doc below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
