shunping commented on code in PR #39834:
URL: https://github.com/apache/beam/pull/39834#discussion_r3831729802


##########
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcReadSchemaTransformProvider.java:
##########
@@ -363,6 +368,11 @@ public abstract static class 
JdbcReadSchemaTransformConfiguration implements Ser
     @Nullable
     public abstract String getReadQuery();
 
+    @SchemaFieldDescription(
+        "Secret Manager to use for fetching secret values. For example, 
GoogleCloudSecretManager.")

Review Comment:
   Done. Added more description and examples for java, python and yaml docs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to