aa-dit-yuh opened a new pull request, #39843:
URL: https://github.com/apache/beam/pull/39843
Fixes #39842
### Problem
When reading from Cloud Bigtable using Apache Beam, reads are processed in
buffered segments. When a segment hits buffer memory limits or row limits
during a read, Beam pauses the stream and calls `truncateRequest` to construct
a new `ReadRowsRequest` for the remainder of the key range starting from
`(start_key_open: lastKey)`.
For key ranges where the open end key is the start key with an appended null
byte (e.g., `[K, K\0)`, common in single-row scans, prefix scans, or dynamic
work rebalancing splits), `EndPoint.compareTo` compares `"K\0"` to `"K"`,
evaluating to `endCmp > 0`. Because `endCmp > 0`, `truncateRequest` did not
skip the range after reading key `K`, and generated a request with
`(start_key_open: K, end_key_open: K\0)`.
Cloud Bigtable server validates `start_key_open` as `K\0` and strictly
enforces `start_key < end_key`. Because `K\0 < K\0` is false, Bigtable server
rejects the request with:
io.grpc.StatusRuntimeException: INVALID_ARGUMENT: Error in field
'row_ranges' : Error in element #0 : start_key must be less than end_key
### Solution
In `BigtableServiceImpl.BigtableSegmentReaderImpl.truncateRequest`, check if
`rowRange.getEndKeyCase() == END_KEY_OPEN` and skip the range if `lastKey +
"\0" >= rowRange.getEndKeyOpen()`.
### Tests
- Added unit test `testReadRangeWithNullByteEndKeyAtByteLimit` in
`BigtableServiceImplTest.java` verifying that ranges with an open null-byte
suffix end key are properly recognized as exhausted during truncation without
generating invalid requests.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [x] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [x] Update `CHANGES.md` with noteworthy changes.
- [x] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
