mutianf commented on code in PR #39843:
URL: https://github.com/apache/beam/pull/39843#discussion_r3832517810
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableServiceImpl.java:
##########
@@ -481,6 +481,14 @@ private ReadRowsRequest truncateRequest(ReadRowsRequest
request, ByteString last
segment.addRowRanges(newRange.build());
} else {
// Row is split, remove all read rowKeys and split RowSet at last
buffered Row
+ if (rowRange.getEndKeyCase() == RowRange.EndKeyCase.END_KEY_OPEN
Review Comment:
I noticed and fixed a similar issue with reconstructing row key ranges
before in the reading large rows logic
https://screenshot-v2.corp.google.com/7dli6t427bceg. Maybe it's worth using
RowSetUtil.erase to handle this here. But this fix in beam looks correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
