lukecwik commented on a change in pull request #13006:
URL: https://github.com/apache/beam/pull/13006#discussion_r499719235
##########
File path:
runners/samza/src/main/java/org/apache/beam/runners/samza/SamzaRunner.java
##########
@@ -107,7 +107,7 @@ public PortablePipelineResult
runPortablePipeline(RunnerApi.Pipeline pipeline) {
@Override
public SamzaPipelineResult run(Pipeline pipeline) {
- SplittableParDo.validateNoPrimitiveReads(pipeline);
+
SplittableParDo.convertReadBasedSplittableDoFnsToPrimitiveReadsIfNecessary(pipeline);
Review comment:
Its a noop if the experiments aren't set. If the experiments are set
then `Read.Bounded` and `Read.Unbounded` get converted into
`PrimitiveBoundedRead` and `PrimitiveUnboundedRead` respectively.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
