lukecwik commented on a change in pull request #13006:
URL: https://github.com/apache/beam/pull/13006#discussion_r499747545
##########
File path:
runners/samza/src/main/java/org/apache/beam/runners/samza/translation/ReadTranslator.java
##########
@@ -54,9 +54,9 @@ public void translate(
final PCollection<T> output = ctx.getOutput(transform);
final Coder<WindowedValue<T>> coder = SamzaCoders.of(output);
final Source<?> source =
- transform instanceof Read.Unbounded
- ? ((Read.Unbounded) transform).getSource()
- : ((Read.Bounded) transform).getSource();
+ transform instanceof SplittableParDo.PrimitiveBoundedRead
Review comment:
I narrowed it down to DoFnOp calling start bundle/finish bundle when
there are no timers to fire. This caused output to get produced when it should
have been. I updated the other Samza Ops that process timers to not process
them when there are no timers to fire.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
