xujiantop-crypto opened a new pull request, #40077: URL: https://github.com/apache/beam/pull/40077
Extract a package-private `OutputWithTimestampDoFn` shared by `WithTimestamps.AddTimestampsDoFn` and `Create.TimestampedValues.ConvertTimestamps`. The existing transform structure is intentionally preserved. In particular, `Create.TimestampedValues` still creates an intermediate `PCollection<TimestampedValue<T>>`, uses `TimestampedValueCoder`, restores the output coder, and retains the `ConvertTimestamps` transform name. This avoids the runner matching issue that previously occurred when `TimestampedValues` inherited from `Create.Values`. `WithTimestamps` continues to preserve its null timestamp validation and allowed timestamp skew behavior. Tests: - `:sdks:java:core:test` for `WithTimestampsTest` and `CreateTest` - `:runners:direct-java:needsRunnerTest` for `WithTimestampsTest` and `CreateTest` - Pipeline renderer tests - `:sdks:java:core:spotlessJavaCheck` - `:sdks:java:core:javadoc` Fixes #18350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
