kennknowles commented on PR #40077: URL: https://github.com/apache/beam/pull/40077#issuecomment-5605427312
Hello! Thanks for contributing! I'm sorry we left that GitHub issue open. I don't actually think we should do this, for two reasons: 1. We should avoid inheritance with abstract members, and use composition instead. 2. This logic is simple enough it is better to just keep it duplicated in multiple places rather than introduce a dependency between them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
